improvement(workflows): centralize v2 application operations - #6411
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
PR SummaryMedium Risk Overview Execute switches from v1-style auth to Deploy / rollback / undeploy responses now surface Resume is split: Removes Reviewed by Cursor Bugbot for commit a5a2bd1. Bugbot is set up for automated code reviews on this repo. Configure here. |
Greptile SummaryThe PR centralizes v2 workflow operations behind Principal-aware application use cases while preserving transport-specific responses and analytics.
Confidence Score: 5/5The PR appears safe to merge because no blocking failure remains within the eligible follow-up-review scope. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| apps/sim/lib/core/application/workspace-authorization.ts | Centralizes workspace authorization for session, personal API-key, workspace API-key, and delegated principals. |
| apps/sim/lib/workflows/application/authorized-workflow-use-case.ts | Wraps workflow operations with canonical context resolution, authorization, and audit projection. |
| apps/sim/app/api/v2/workflows/[id]/execute/route.ts | Routes keyed execution through shared request admission and the centralized execution operation while retaining anonymous public execution behavior. |
| apps/sim/lib/workflows/executor/resume-execution.ts | Consolidates paused-snapshot validation, preprocessing, resume claiming, execution-mode selection, dispatch, and cleanup. |
| apps/sim/lib/workflows/application/deployments.ts | Exposes authorized deploy, undeploy, and version-activation use cases over shared lifecycle orchestration. |
| apps/sim/lib/workflows/orchestration/deploy.ts | Coordinates stable deployment transitions and transactional deployment-outbox preparation. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart LR
Client[API client or internal caller] --> Adapter[Route adapter]
Adapter --> Auth[Principal authentication and rate admission]
Auth --> UseCase[Authorized workflow use case]
UseCase --> Context[Canonical workflow and workspace context]
Context --> Authorization[Workspace authorization]
Authorization --> Operation[Workflow operation]
Operation --> Lifecycle[CRUD, deployment, execution, runs, or resume]
Lifecycle --> Presenter[Surface-specific response, analytics, and audit]
Presenter --> Client
Reviews (2): Last reviewed commit: "fix(workflows): avoid locking folder tre..." | Re-trigger Greptile
|
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit a5a2bd1. Configure here.
Summary
Type of Change
Testing
Checklist